Analytics Hub: Fix UI access from a background thread. #8306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ecarrion
added
the
category: tracks
Collaborator
You can test the changes from this Pull Request by:
|
rachelmcr
approved these changes
Dec 5, 2022
Contributor
rachelmcr
left a comment
rachelmcr
left a comment
There was a problem hiding this comment.
Thanks for fixing this! I'd just noticed the warnings, too. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
While testing the error state on the Products Card, I noticed that Xcode started to show some strange warnings about published variables being accessed from a background thread.
After a quick look, I noticed that the
switchToErrorState()method is called from an async function.This PR fixes that by annotating methods that update our published variables with the
@MainActorattribute.RELEASE-NOTES.txtif necessary.